[SDK-3870] refactor: send react-hooks agent as channel param #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
owenpearson
force-pushed
the
react-hooks-agent-channel-param
branch
from
6a4c2e4 to
2261c52
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
owenpearson
force-pushed
the
react-hooks-agent-channel-param
branch
from
2261c52 to
a6465ef
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
github-actions
bot
temporarily deployed
to
staging/pull/1459/bundle-report
owenpearson
force-pushed
the
react-hooks-agent-channel-param
branch
from
a6465ef to
695e5bb
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
github-actions
bot
temporarily deployed
to
staging/pull/1459/bundle-report
ttypic
reviewed
Oct 4, 2023
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
github-actions
bot
temporarily deployed
to
staging/pull/1459/bundle-report
owenpearson
force-pushed
the
react-hooks-agent-channel-param
branch
from
d871de0 to
5f14a5c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1459/features
github-actions
bot
temporarily deployed
to
staging/pull/1459/bundle-report
This internal change makes the client more selective about which options provided to `channels.get` will be interpreted as requiring reattachment. More precisely, the channel params and modes will now be shallow compared to existing params and modes, and only if they differ will the call the `chnanels.get` throw an error (, provided of course that the channel is already attached or attaching).
owenpearson
force-pushed
the
react-hooks-agent-channel-param
branch
from
5f14a5c to
f38c5a7
Compare
ttypic
requested changes
Oct 19, 2023
ttypic
approved these changes
Oct 19, 2023
owenpearson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends the
react-hooksagent as a channel param (workaround since typically the ably client used by react hooks already starts connecting before the hooks wrapper has an opportunity to add the agent as a transport param).This branch also contains a change to make the client more selective about which options provided to
channels.getwill be interpreted as requiring reattachment. More precisely, the channel params and modes will now be shallow compared to existing params and modes, and only if they differ will the call thechnanels.getthrow an error (provided of course that the channel is already attached or attaching).